Title: Update configuration to support custom libraries and exclusion of default isort rules #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelcolvin
requested changes
May 6, 2025
Comment on lines
-75
to
+77
| if self.ruff_ignore: | ||
| if self.first_party: | ||
| args.append(f'--first-party={",".join(self.first_party)}') |
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request aims to address the issue titled "more ruff configuration" by providing support for custom first party libraries and allowing the configuration file to define additional settings. Currently, the default behavior includes
I(isort rules) even whenisort=False, which is not ideal.Changes Made
I(isort rules) when theisortparameter is set toFalse.Related Issue
Closes #issue_number
How to Test
isort=Falseand ensure thatI(isort rules) are excluded as expected.Screenshots
(Optional: Include any relevant screenshots to demonstrate the changes, if applicable)
Please review and merge this pull request. Thank you!