Fix typos and replace deprecated function (#865)

* Fix typos and ignore false positives found by codespell * Deprecated pydicom function: read_file → dcmread * Reformat with black
pydicom · Oct 8, 2023 · ca798a7 · ca798a7
1 parent 2aa9ed7
commit ca798a7
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 11 deletions.
diff --git a/.github/workflows/pr-linter.yml b/.github/workflows/pr-linter.yml
@@ -42,7 +42,7 @@ jobs:
     - name: Check code formatting
       run: black . --check
     - name: Check spelling
-      run: codespell -L halp,ot,pres,requestor,requestors -d pynetdicom
+      run: codespell -L ddress,halp,ot,pres,requestor,requestors -d pynetdicom
     - name: Check for syntax errors
       run: python -m flake8 --select=E901,E999,F822,F823 ${{ steps.pydiff.outputs.pyfiles }} --ignore F821
     - name: Check for style warnings

diff --git a/docs/apps/movescu.rst b/docs/apps/movescu.rst
@@ -522,7 +522,7 @@ SOP Classes
 +----------------------------------+------------------------------------------+
 | 1.2.840.10008.5.1.4.1.1.481.10   | RT Physician Intent Storage              |
 +----------------------------------+------------------------------------------+
-| 1.2.840.10008.5.1.4.1.1.481.11   | RT Segmentation Annotation Storge        |
+| 1.2.840.10008.5.1.4.1.1.481.11   | RT Segmentation Annotation Storage       |
 +----------------------------------+------------------------------------------+
 | 1.2.840.10008.5.1.4.1.1.481.12   | RT Radiation Set Storage                 |
 +----------------------------------+------------------------------------------+

diff --git a/pynetdicom/_handlers.py b/pynetdicom/_handlers.py
@@ -3509,7 +3509,7 @@ def doc_handle_n_get(event: "Event", *args: Sequence[Any]) -> UserReturnType:
     * :dcm:`Media Creation Management<part04/chapter_S.html>`
     * :dcm:`Unified Procedure Step<part04/chapter_CC.html>`
     * :dcm:`RT Machine Verification<part04/chapter_DD.html>`
-    * :dcm:`Dispaly System Management<part04/chapter_EE.html>`
+    * :dcm:`Display System Management<part04/chapter_EE.html>`
 
     **Status**
 

diff --git a/pynetdicom/apps/findscu/findscu.py b/pynetdicom/apps/findscu/findscu.py
@@ -290,7 +290,7 @@ def main(args=None):
 
     # Create query (identifier) dataset
     try:
-        # If you're looking at this to see how QR Find works then `identifer`
+        # If you're looking at this to see how QR Find works then `identifier`
         # is a pydicom Dataset instance with your query keys, e.g.:
         #     identifier = Dataset()
         #     identifier.QueryRetrieveLevel = 'PATIENT'

diff --git a/pynetdicom/apps/getscu/getscu.py b/pynetdicom/apps/getscu/getscu.py
@@ -240,7 +240,7 @@ def main(args=None):
 
     # Create query (identifier) dataset
     try:
-        # If you're looking at this to see how QR Get works then `identifer`
+        # If you're looking at this to see how QR Get works then `identifier`
         # is a pydicom Dataset instance with your query keys, e.g.:
         #     identifier = Dataset()
         #     identifier.QueryRetrieveLevel = 'PATIENT'

diff --git a/pynetdicom/apps/movescu/movescu.py b/pynetdicom/apps/movescu/movescu.py
@@ -273,7 +273,7 @@ def main(args=None):
 
     # Create query (identifier) dataset
     try:
-        # If you're looking at this to see how QR Move works then `identifer`
+        # If you're looking at this to see how QR Move works then `identifier`
         # is a pydicom Dataset instance with your query keys, e.g.:
         #     identifier = Dataset()
         #     identifier.QueryRetrieveLevel = 'PATIENT'

diff --git a/pynetdicom/tests/test_ae.py b/pynetdicom/tests/test_ae.py
@@ -8,7 +8,7 @@
 
 import pytest
 
-from pydicom import read_file, config as PYD_CONFIG
+from pydicom import dcmread, config as PYD_CONFIG
 from pydicom.dataset import Dataset
 from pydicom.uid import UID, ImplicitVRLittleEndian
 
@@ -37,10 +37,8 @@
 
 
 TEST_DS_DIR = os.path.join(os.path.dirname(__file__), "dicom_files")
-DATASET = read_file(os.path.join(TEST_DS_DIR, "RTImageStorage.dcm"))
-COMP_DATASET = read_file(
-    os.path.join(TEST_DS_DIR, "MRImageStorage_JPG2000_Lossless.dcm")
-)
+DATASET = dcmread(os.path.join(TEST_DS_DIR, "RTImageStorage.dcm"))
+COMP_DATASET = dcmread(os.path.join(TEST_DS_DIR, "MRImageStorage_JPG2000_Lossless.dcm"))
 
 
 def test_blocking_handler():