This repository has been archived by the owner on Aug 15, 2021. It is now read-only.
Support MSRV of 1.36 #190
Open
Support MSRV of 1.36 #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that you changed the MSRV to 1.40 in 026b121.
However, version 1.36 is currently supported (1.32 would be without
alloc]. Only supporting "latest stable" (which in itself changes almost every month) can cause significant pain for people that are not using rustup or installing Rust manually.The vast majority of production systems will rely on Linux distribution package repositories to install Rust, such as the Debian or CentOS repos.
At present, Debian stable has v1.34, CentOS 8 has 1.39 and CentOS 7 has 1.26.
Given that serde itself supports rustc as old as 1.13, it makes sense to also try to support an older version as long as it doesn't pose a significant maintenance burden.
Since I'll be using this crate myself, I'd be glad to help maintain this support.