Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using AI tools to improve commenting of base G-retriever example #9882

Merged
merged 23 commits into from
Jan 7, 2025
Merged

Using AI tools to improve commenting of base G-retriever example #9882

merged 23 commits into from
Jan 7, 2025
+148 −24

Conversation

puririshi98
Copy link
Contributor

No description provided.

@puririshi98 puririshi98 requested a review from wsad1 as a code owner December 21, 2024 00:49
akihironitta
akihironitta reviewed Dec 21, 2024
View reviewed changes
Copy link
Member

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nicer :) Can we also remove too redundant comments like these? IMO, any comments for code that can easily be understood within 0.1 seconds are too redundant.

examples/llm/g_retriever.py Outdated Show resolved Hide resolved
examples/llm/g_retriever.py Outdated Show resolved Hide resolved
examples/llm/g_retriever.py Outdated Show resolved Hide resolved
@puririshi98
Copy link
Contributor Author

@akihironitta did another run through. this time i did a manuall checking for each one. (the LLM went a little crazy overcommenting haha)

@puririshi98
Copy link
Contributor Author

please merge when you think it looks good, LGTM

@puririshi98 puririshi98 changed the title Using AI tools to improve commenting of base G-retriever example Draft: Using AI tools to improve commenting of base G-retriever example Dec 21, 2024
@puririshi98
Copy link
Contributor Author

need to test before merge actualy

@puririshi98 puririshi98 changed the title Draft: Using AI tools to improve commenting of base G-retriever example Using AI tools to improve commenting of base G-retriever example Jan 7, 2025
@puririshi98 puririshi98 merged commit 8a651b3 into master Jan 7, 2025
16 checks passed
@puririshi98 puririshi98 deleted the AI-cleanup branch January 7, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akihironitta akihironitta akihironitta approved these changes

@rusty1s rusty1s Awaiting requested review from rusty1s

@wsad1 wsad1 Awaiting requested review from wsad1 wsad1 is a code owner

Assignees
No one assigned
Labels
example skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puririshi98 @akihironitta