Skip to content

wasm: unify pygame-web/pyodide/static Freetype init #2748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

pmp-p
Copy link
Member

@pmp-p pmp-p commented Mar 11, 2024

both pygbag and pyodide benefit from that change see
pyodide/pyodide#4602 (review)

part of the change already was in anyway

static int font_initialized = 1;
and the other part was in a patch applied by pygbag because the draft #1967 was incomplete.

@pmp-p pmp-p requested a review from a team as a code owner March 11, 2024 17:24
@pmp-p pmp-p mentioned this pull request Mar 11, 2024
3 tasks
@oddbookworm
Copy link
Member

@pmp-p
Copy link
Member Author

pmp-p commented Mar 11, 2024

weird with the lastest sdk it builds locally, now i'm not sure i want to upgrade the one from the CI which seems more sane :)

Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a WASM expert, but this change makes sense, so I'm approving. Thanks 🎉

@Starbuck5 Starbuck5 merged commit 89dfdb5 into pygame-community:main Mar 13, 2024
@Starbuck5 Starbuck5 added this to the 2.5.0 milestone Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants