FIx PySequence_AsVectorCoords and discourage usage #3487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever is
PySequence_AsVectorCoords
is called without callingpgVectorCompatible_Check
beforehand, currently the code gives undefined behaviour when expected dim is 3 and a Vector2 is passed. If expected dim is 2 and Vector3 is passed the 3rd component gets ignored. For now I fixed the undefined behaviour case to ensure consistent 0-ing.I renamed this function to
pg_VectorCoordsFromObjOldDontUseInNewCode
so that new API doesn't end up using this function. New API should just usepg_VectorCoordsFromObj
directly.Wherever
pgVectorCompatible_Check
was already being called beforePySequence_AsVectorCoords
we can safely use the newpg_VectorCoordsFromObj
API