Fix FRect contains error message

[Hato1]

FRect requires a float as the left operand but the error message says it requires an int.

Before this PR:

>>> fr = pygame.FRect(10,20,30,40)
>>> 10 in fr
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: 'in <pygame.rect.FRect>' requires rect style object or int as left operand

After:

>>> fr = pygame.FRect(10,20,30,40)
>>> 10 in fr
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: 'in <pygame.rect.FRect>' requires rect style object or float as left operand

Resolves #3533

[Starbuck5]

The rect_impl template is compiled separately for Rect and FRect, it shouldn't need a runtime check inside itself to determine which type is which. I was thinking a new define could be added to rect.c to communicate the type name as a string to the implementation. Or perhaps even there's a way to treat the C type that's already communicated as a string.

[MightyJosip]

Starbuck what do you think about something like this

diff --git a/src_c/rect.c b/src_c/rect.c
index 155f97faf..c9097096a 100644
--- a/src_c/rect.c
+++ b/src_c/rect.c
@@ -49,6 +49,7 @@ static int
 four_floats_from_obj(PyObject *obj, float *val1, float *val2, float *val3,
                      float *val4);

+#define IS_RECT
 #define RectExport_init pg_rect_init
 #define RectExport_subtypeNew4 _pg_rect_subtype_new4
 #define RectExport_new pg_rect_new
@@ -165,7 +166,9 @@ four_floats_from_obj(PyObject *obj, float *val1, float *val2, float *val3,
 #define RectOptional_Freelist_Num pg_rect_freelist_num
 #endif /* PYPY_VERSION */
 #include "rect_impl.h"
+#undef IS_RECT

+#define IS_FRECT
 #define RectExport_init pg_frect_init
 #define RectExport_subtypeNew4 _pg_frect_subtype_new4
 #define RectExport_new pg_frect_new
@@ -282,6 +285,7 @@ four_floats_from_obj(PyObject *obj, float *val1, float *val2, float *val3,
 #define RectOptional_Freelist_Num pg_frect_freelist_num
 #endif /* PYPY_VERSION */
 #include "rect_impl.h"
+#undef IS_FRECT

diff --git a/src_c/rect_impl.h b/src_c/rect_impl.h
index 9018f9522..51b474637 100644
--- a/src_c/rect_impl.h
+++ b/src_c/rect_impl.h
@@ -1997,13 +1997,16 @@ RectExport_containsSeq(RectObject *self, PyObject *arg)

     int ret = RectExport_contains_internal(self, (PyObject *const *)&arg, 1);
     if (ret < 0) {
-        const char *operand_type =
-            pgFRect_Check((PyObject *)self) ? "float" : "int";
-
+#if defined(IS_RECT)
+#define OperandType "int"
+#elif defined(IS_FRECT)
+#define OperandType "float"
+#endif
         PyErr_Format(
             PyExc_TypeError,
             "'in %s' requires rect style object or %s as left operand",
-            ObjectName, operand_type);
+            ObjectName, OperandType);
+#undef OperandType
     }
     return ret;
 }

[Starbuck5]

I think it would be simpler if you defined operandtype directly on the outer layer without the ISRECT/ISFRECT indirection.

Also I'd think should be able to be compiled into the string that goes into PyErr_Format.