Skip to content

Commit

Permalink
Changes requested by reviewers
Browse files Browse the repository at this point in the history
  • Loading branch information
fyellin committed Nov 7, 2024
1 parent 466d3d9 commit 54488dc
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions wgpu/backends/wgpu_native/_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -1069,7 +1069,9 @@ class GPUDevice(classes.GPUDevice, GPUObjectBase):
# GPUObjectBaseMixin
_release_function = libf.wgpuDeviceRelease

CREATE_PIPELINE_ASYNC_NOT_IMPLEMENTED = True
# This flag should be deleted once create_compute_pipeline_async() and
# create_render_pipeline_async() are actually implemented in the wgpu-native library.
_CREATE_PIPELINE_ASYNC_NOT_IMPLEMENTED = True

def _poll(self):
# Internal function
Expand Down Expand Up @@ -1573,7 +1575,7 @@ async def create_compute_pipeline_async(
):
descriptor = self._create_compute_pipeline_descriptor(label, layout, compute)

if self.CREATE_PIPELINE_ASYNC_NOT_IMPLEMENTED:
if self._CREATE_PIPELINE_ASYNC_NOT_IMPLEMENTED:
# H: WGPUComputePipeline f(WGPUDevice device, WGPUComputePipelineDescriptor const * descriptor)
id = libf.wgpuDeviceCreateComputePipeline(self._internal, descriptor)
return GPUComputePipeline(label, id, self)
Expand Down Expand Up @@ -1675,7 +1677,7 @@ async def create_render_pipeline_async(
label, layout, vertex, primitive, depth_stencil, multisample, fragment
)

if self.CREATE_PIPELINE_ASYNC_NOT_IMPLEMENTED:
if self._CREATE_PIPELINE_ASYNC_NOT_IMPLEMENTED:
# H: WGPURenderPipeline f(WGPUDevice device, WGPURenderPipelineDescriptor const * descriptor)
id = libf.wgpuDeviceCreateRenderPipeline(self._internal, descriptor)
return GPURenderPipeline(label, id, self)
Expand Down

0 comments on commit 54488dc

Please sign in to comment.