Actually run the tests instead of fully skipping them #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure what else in #604 needs to be "reworked" |
hmaarrfk
commented
Dec 30, 2024
hmaarrfk
commented
Dec 30, 2024
hmaarrfk
force-pushed
the
patch-3
branch
2 times, most recently
from
c26d6fa to
ee0e9a8
Compare
hmaarrfk
commented
Dec 30, 2024
Korijn
approved these changes
Dec 30, 2024
Its easy to "fix tests" by completely skipping them ^_^_^_^_^
…n regenereate the images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its easy to "fix tests" by completely skipping them ^^^^^