Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] polars complete function #1367

Merged
merged 78 commits into from
Jun 14, 2024
Merged

[ENH] polars complete function #1367

merged 78 commits into from
Jun 14, 2024

Conversation

samukweku
Copy link
Collaborator

@samukweku samukweku commented May 24, 2024

PR Description

Please describe the changes proposed in the pull request:

  • Add complete method for polars

This PR relates to #1352 .

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.md.
  1. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

Copy link

codecov bot commented May 25, 2024

Codecov Report

Attention: Patch coverage is 96.05263% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.93%. Comparing base (62c57c6) to head (af09c7a).
Report is 19 commits behind head on dev.

Current head af09c7a differs from pull request most recent head 0f24a6e

Please upload reports for the commit 0f24a6e to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1367      +/-   ##
==========================================
- Coverage   94.48%   85.93%   -8.55%     
==========================================
  Files          80       83       +3     
  Lines        4367     4820     +453     
==========================================
+ Hits         4126     4142      +16     
- Misses        241      678     +437     

Copy link
Member

@ericmjl ericmjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thank you @samukweku!

@ericmjl ericmjl merged commit d912a5e into dev Jun 14, 2024
4 checks passed
@ericmjl ericmjl deleted the samukweku/polars_complete branch June 14, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants