Typos, wrong links and file added into .gitignore #12
Conversation
Add updates from Pyladies
Not that important, but why not? :)
Once more nothing that important, but I think it is worthy. Excuse me for not commiting the last pull request together, I haven't seen this one before.
As suggested in 2-influxdb.md
I suppose that everybody who followed the tutorial till now will have this file in the same folder in Raspberry pi. Nohup won't find it by giving only the file name.
.gitignore
Outdated
| data-collecting/pubnub.ini | ||
| data-collecting/send-pubnub.py |
There was a problem hiding this comment.
was this one on purpose? I think it will remove the python script from the repo
There was a problem hiding this comment.
You're right! I thought it would be a good idea to let it in .gitignore as default, because it contains real sensitive data. One possibility would be to rename send-pubnub.py to send-pubnub-template.py. What do you think?
There was a problem hiding this comment.
the private data is in the pubnub.ini config and not in the code. The pubnub.ini is in the gitignore, and we got a template that is public. So the send-pubnub.py has only code and reads from a private config file, pls check that that is the same in your setup
There was a problem hiding this comment.
Hi Tereza, you're right. I missunderstood what was written. You suggest to add the log file to gitignore and not the send-pubnub.py file. I'll fix this part. :)
So that the user just has to uncomment the file before submitting to github.
Now you just have to uncomment the file to avoid that sensitive data is uploaded to github.
Hi,
I noticed some mistakes in the files and corrected them. Feel free to accept it or not.
Bests,
Tai