Migrate from isort and flake8 to ruff #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlio
reviewed
Oct 30, 2023
| - repo: https://github.com/psf/black | ||
| rev: 23.10.1 | ||
| hooks: | ||
| - id: black | ||
| args: [--safe, --line-length=120] | ||
| - repo: https://github.com/PyCQA/isort |
There was a problem hiding this comment.
Do ruff + black play well together for sorting imports? I remember that isort came after black due to them conflicting, however that was some time ago and likely fixed.
There was a problem hiding this comment.
Yeah ruff went out after black so it supports it without config. (there's also ruffmt now, but I like black for having only one option).
Pierre-Sassoulas
force-pushed
the
migrate-from-isort-and-flake8-to-ruff
branch
from
547e1cd to
38a71d4
Compare
Pierre-Sassoulas
force-pushed
the
migrate-from-isort-and-flake8-to-ruff
branch
from
38a71d4 to
2a5ac32
Compare
carlio
approved these changes
Nov 4, 2023
Pierre-Sassoulas
force-pushed
the
migrate-from-isort-and-flake8-to-ruff
branch
2 times, most recently
from
cd78a83 to
731fba3
Compare
|
Yeah, I had to rebase on everything to make it work 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #412 #413. Also need some workflow changes.