-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Vendor 'mccabe' to reduce supply chain risks and optimize analysis later #10551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Pierre-Sassoulas
wants to merge
4
commits into
main
Choose a base branch
from
vendored-mccabe
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (98.66%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #10551 +/- ##
=======================================
Coverage 95.89% 95.90%
=======================================
Files 176 176
Lines 19416 19429 +13
=======================================
+ Hits 18619 18633 +14
+ Misses 797 796 -1
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
a799a4f
to
1863240
Compare
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
added a commit
that referenced
this pull request
Sep 21, 2025
## Type of Changes <!-- Leave the corresponding lines for the applicable type of change: --> | | Type | | --- | ---------------------- | | ✓ | 📜 Docs | ## Description Refs #10551
1863240
to
035e9e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Maintenance
Discussion or action around maintaining pylint or the dev workflow
Needs decision 🔒
Needs a decision before implemention or rejection
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Draft following #9667. Seems like a lot of optimization can be done by having the code directly in pylint. typing, and removing inheritance, and edge's name handling in particular. Because we're using a tool that permits to draw graph and we don't want to draw anything, we just want to get the damn mccabe metric.