Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions doc/whatsnew/fragments/10707.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Fix crash for ``consider-using-assignment-expr`` when a variable annotation without assignment
is used as the ``if`` test expression.

Closes #10707
2 changes: 1 addition & 1 deletion pylint/extensions/code_style.py
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ def _check_prev_sibling_to_if_stmt(
case nodes.Assign(
targets=[nodes.AssignName(name=target_name)]
) | nodes.AnnAssign(target=nodes.AssignName(name=target_name)):
return target_name == name # type: ignore[no-any-return]
return target_name == name and prev_sibling.value is not None
return False

@staticmethod
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -157,3 +157,8 @@ class A:
A.var = 2
if A.var:
...


i: int
if i: # pylint: disable=used-before-assignment
pass