-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement several subtensor lift rewrites #1158
Draft
ricardoV94
wants to merge
11
commits into
pymc-devs:main
Choose a base branch
from
ricardoV94:subtensor_lift
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
subtensor_lift
branch
3 times, most recently
from
January 20, 2025 17:56
cbe0c96
to
9b47cee
Compare
ricardoV94
changed the title
Implement sereval subtensor lift rewrites
Implement several subtensor lift rewrites
Jan 21, 2025
ricardoV94
force-pushed
the
subtensor_lift
branch
from
January 21, 2025 09:08
9b47cee
to
d1b5784
Compare
This reduces the number of passes, as other rewrites don't really care about the dtype of the indices, and can easily introduce non-uint index operations
ricardoV94
force-pushed
the
subtensor_lift
branch
from
January 30, 2025 10:31
d1b5784
to
d72b5c2
Compare
Split off Subtensor of Unbroadcast into its own rewrite
ricardoV94
force-pushed
the
subtensor_lift
branch
from
January 30, 2025 14:42
d72b5c2
to
23870fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows reducing computations on batch dimensions by lifting simple indexing operations closer to the inputs.
An obvious example is:
📚 Documentation preview 📚: https://pytensor--1158.org.readthedocs.build/en/1158/