-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speedup scalar Op python implementations #1169
base: main
Are you sure you want to change the base?
Conversation
f8abadb
to
866f488
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (47.61%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1169 +/- ##
==========================================
+ Coverage 82.11% 82.27% +0.16%
==========================================
Files 186 186
Lines 48201 47927 -274
Branches 8679 8623 -56
==========================================
- Hits 39579 39434 -145
+ Misses 6447 6334 -113
+ Partials 2175 2159 -16
|
Looks good, but there are two more |
definitely, missed those |
866f488
to
289067c
Compare
289067c
to
e4547cd
Compare
Some cleanup of unused code in scalar/math.py.
Also speedup a bit the perform method by avoiding allocating intermediate variables and attribute acces for a helper function
📚 Documentation preview 📚: https://pytensor--1169.org.readthedocs.build/en/1169/