Fix to minor bug in simulated data generation function #505
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #433
I believe the answer to this is "no". The
beta_intercept
input is being used in the data generation process, but the purpose ofdf["intercept"] = np.ones(df.shape[0])
is to create input data for modelling where it's common to create a column of zeros. Though practically I think this is not needed or is even being used because it's being taken care of bypatsy
based on the user-provided model formula. But for the moment I've just added an explanatory comment.📚 Documentation preview 📚: https://causalpy--505.org.readthedocs.build/en/505/