Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ModifiedBetaGeoNBD and ModifiedBetaGeoNBDRV #1375

Merged
merged 9 commits into from
Jan 18, 2025

Conversation

PabloRoque
Copy link
Contributor

@PabloRoque PabloRoque commented Jan 15, 2025

Description

This PR is equivalent to #1317, now tackling ModifiedBetaGeoNBD and ModifiedBetaGeoNBDRV.

  • Adds ModifiedBetaGeoNBD distribution
  • Adds ModifiedBetaGeoNBDRV
  • Introduces recency_frequency sampling from ModifiedBetaGeoNBD in ModifiedBetaGeoModel.distribution_new_customer

Related Issue

Checklist

Modules affected

  • MMM
  • CLV
  • Customer Choice

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.65%. Comparing base (75ee409) to head (239545b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1375      +/-   ##
==========================================
+ Coverage   94.59%   94.65%   +0.05%     
==========================================
  Files          48       48              
  Lines        5202     5257      +55     
==========================================
+ Hits         4921     4976      +55     
  Misses        281      281              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PabloRoque PabloRoque marked this pull request as ready for review January 15, 2025 15:35
@juanitorduz juanitorduz requested a review from ColtAllen January 15, 2025 20:03
Copy link
Collaborator

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @PabloRoque ! It looks good to me, but I would ask @ColtAllen for a detailed review before merging 🙏

pymc_marketing/clv/distributions.py Show resolved Hide resolved
@PabloRoque
Copy link
Contributor Author

Thank you @PabloRoque ! It looks good to me, but I would ask @ColtAllen for a detailed review before merging 🙏

Thanks for having a look.

Let's wait for @ColtAllen review. I am sure he'll come up with some nice suggestions.

Copy link
Collaborator

@ColtAllen ColtAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of overlapping work here with #1390. Let's go ahead and merge this so the other PR can just focus on covariates. I'll double-check the docs before the next release.

@ColtAllen ColtAllen dismissed their stale review January 18, 2025 18:29

My mistake - the sim_data function looks good!

@ColtAllen ColtAllen merged commit 8a0b076 into pymc-labs:main Jan 18, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants