-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ModifiedBetaGeoNBD and ModifiedBetaGeoNBDRV #1375
Conversation
…taGeoModel. Add some tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1375 +/- ##
==========================================
+ Coverage 94.59% 94.65% +0.05%
==========================================
Files 48 48
Lines 5202 5257 +55
==========================================
+ Hits 4921 4976 +55
Misses 281 281 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @PabloRoque ! It looks good to me, but I would ask @ColtAllen for a detailed review before merging 🙏
Thanks for having a look. Let's wait for @ColtAllen review. I am sure he'll come up with some nice suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of overlapping work here with #1390. Let's go ahead and merge this so the other PR can just focus on covariates. I'll double-check the docs before the next release.
My mistake - the sim_data
function looks good!
Description
This PR is equivalent to #1317, now tackling
ModifiedBetaGeoNBD
andModifiedBetaGeoNBDRV
.ModifiedBetaGeoNBD
distributionModifiedBetaGeoNBDRV
ModifiedBetaGeoNBD
inModifiedBetaGeoModel.distribution_new_customer
Related Issue
Checklist
Modules affected
Type of change