-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support xarray in ModelBuilder #1459
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1459 +/- ##
==========================================
+ Coverage 94.63% 94.75% +0.12%
==========================================
Files 50 50
Lines 5458 5457 -1
==========================================
+ Hits 5165 5171 +6
+ Misses 293 286 -7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No comments, awesome!
Tagging @ColtAllen since he said that it is related to CLV PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the required CLV changes will need to be done in a separate PR, because other than the updated type hints for build_model
, none of the revised ModelBuilder methods are being used in the CLV module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
Description
Expanding the support of the ModelBuilder to include xarray types
The
create_fit_data
method in the ModelBuilder class acts to generate the data that will be used to fit the model. There will be a base implementation. However, the user can override this method without touchingfit
directly.The
_generate_and_process_model_data
is no longer required method of the ModelBuilder class. Thebuild_model
method can do this directly or the user has the ability to make custom methods which can act similarly.Related Issue
Checklist
pre-commit.ci autofix
to auto-fix.📚 Documentation preview 📚: https://pymc-marketing--1459.org.readthedocs.build/en/1459/