[MMM] Model events as gaussian bumps #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1465 +/- ##
==========================================
+ Coverage 94.68% 94.80% +0.11%
==========================================
Files 50 51 +1
Lines 5456 5505 +49
==========================================
+ Hits 5166 5219 +53
+ Misses 290 286 -4 ☔ View full report in Codecov by Sentry. |
wd60622
reviewed
Feb 4, 2025
wd60622
reviewed
Feb 4, 2025
wd60622
reviewed
Feb 4, 2025
wd60622
reviewed
Feb 4, 2025
juanitorduz
force-pushed
the
special_events_gauss
branch
from
6627b60 to
cf15205
Compare
|
@wd60622 I did some cleanup and added some tests and docs. Please let me know what do you think about it and also feel free to push directly to the branch. I a next PR I will add other even models (from my blog) |
wd60622
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gaussian bumps are very common to model events, see for example https://juanitorduz.github.io/bump_func/
📚 Documentation preview 📚: https://pymc-marketing--1465.org.readthedocs.build/en/1465/