-
Notifications
You must be signed in to change notification settings - Fork 4
[WIP] feat: update icons #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
- Coverage 64.79% 64.71% -0.08%
==========================================
Files 18 18
Lines 1156 1162 +6
==========================================
+ Hits 749 752 +3
- Misses 407 410 +3 ☔ View full report in Codecov by Sentry. |
yeah... anything that uses setStyleSheet is something I'm going to have difficulty with, except in specific cases (such as something like #39 where it never needs to blend in to its surroundings) I'd like to have some sort of theme idea in place (#4) before we start picking colors that look good ad hoc |
I was starting to look a bit at themeing in https://github.com/tlambert03/pymmcore-gui/tree/theme (diff) |
Not unrelated, but definitely related to #4 We need a global awareness of theme, and it should include colors of icons, backgrounds, etc |
@gselzer and I found that if you switch the Accent Color in Windows's Settings > Personalization > Colors, then Qt will use that color for highlighting the buttons. |
Using
pymmcore-gui
onWindows
, I noticed that the toolbaricons
looked quite thin, the mouse hovering was not very visible and the toggle state on/of was not clear.In this PR I tried to modify the look/behavior of the icon. The color I choose are simply to make the change clear, but we can discuss about the palette.
Screen.Recording.2025-02-16.at.11.19.50.AM.mov