Stricter types with pyright

[alexrudd2]

pyright is another type-checker that finds some things that mypy does not.

Currently there are 42 errors in dev, which this PR reduces to 6. EDIT: 32.

Several of them are false positives from imports and byte/bytearray confusion.
However, many are mismatched type signatures between classes and subclasses that are easy enough to improve.

I have split different types of changes into different commits so they can be cherry-picked or reverted if desired.

[janiversen]

Not bad, but I think you did a bit too much search/replace, especially the _x parameters give important information.

[alexrudd2]

I fully expected some pushback on the _unused_arg / unused_arg so they're in separate commits.

Alternatives:

class Base:
    def method(arg):
        return arg

# this PR - keep identical signatures
class Derived:
    def method(arg):
        pass

# explicit suppress
class Derived_ignore:   # type:ignore[reportIncompatibleMethodOverride]   
    def method(_arg):   
        pass

# fake usage
class Derived_assign:
    def method(arg):
        _ = arg

# unpacking
class Derived_kwargs:
   def method(*args, **kwargs):
      pass

[janiversen]

But this is wrong !! it does not make sense to demand that positional parameters have the same name in inherited classes....I would consider that a general false positive.

[alexrudd2]

But this is wrong !! it does not make sense to demand that positional parameters have the same name in inherited classes....I would consider that a general false positive.

Disagree, although it's not a particularly big deal if using positional args: https://en.wikipedia.org/wiki/Liskov_substitution_principle

[alexrudd2]

Anyways, I have removed the contentious commits for another day. Do you agree with c3ed1b1 or should I revert that as well?
#2731 (comment)

[janiversen]

I think you made that commit a separate PR, which I have approved.

[alexrudd2]

I think you made that commit a separate PR, which I have approved.

Yes, if you can't solve a problem... remove it 😆

Anyways, I think this PR I ready.

[janiversen]

Let me take a look.

[janiversen]

LGTM, thanks.