[WIP] Implementing Helmholtz EOS #724
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yut23
reviewed
Feb 21, 2024
Comment on lines
+78
to
+82
| f_local = np.empty((self.imax, self.jmax, 9)) | ||
| for j in range(0,self.jmax): | ||
| for i in range(0,self.imax): | ||
| line = file.readline() | ||
| f_local[i,j,:] = _extract_line_data(line)[:] |
There was a problem hiding this comment.
This would probably be faster with np.loadtxt
| # interpolation: | ||
| #============================================================ | ||
|
|
||
| def _read_wd(self, der=0, sel='biquintic'): |
There was a problem hiding this comment.
_read_wd() and _read_wt() are almost identical: most of the code should be pulled out into a shared helper function
Comment on lines
+268
to
+271
| psi[0] = self._psi0(x) | ||
| psi[1] = self._psi0(1-x) | ||
| psi[2] = self._psi1(x) | ||
| psi[3] = self._psi1(1-x) |
There was a problem hiding this comment.
these should be self._xpsi*
| psi[2] = self._ddpsi1(y) | ||
| psi[3] = self._ddpsi1(1-y) | ||
| psi[4] = self._ddpsi2(y) | ||
| psi[5] = self._ddpsi2(y) |
There was a problem hiding this comment.
this should be self._ddpsi2(1-y)
Comment on lines
+421
to
+424
| psi[0] = self._psi0(y) | ||
| psi[1] = self._psi0(1-y) | ||
| psi[2] = self._psi1(y) | ||
| psi[3] = self._psi1(1-y) |
There was a problem hiding this comment.
these should be self._xpsi*
Comment on lines
+443
to
+446
| psi[0] = self._psi0(y) | ||
| psi[1] = self._psi0(1-y) | ||
| psi[2] = self._psi1(y) | ||
| psi[3] = self._psi1(1-y) |
There was a problem hiding this comment.
these should be self._xdpsi*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #518. My local fork was dirty and I decided to clean it up, so no commits from older projects appear in my new PR's. I apologize for the inconvenient.