cleanup: annotations future #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…couple type errors
Use annotations future for CMSISDAPProbe, DebugProbe, and StlinkProbe.
Also ignore some type errors that are not problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch migrates a few key modules to use the annotations future so forward type annotations don't have to be strings.
As part of this change, the
@command()decorator for user scripts will work now if the user script uses the annotations future. It doesn't, however, support type annotations that are strings in the source. But since the valid set of type is very small for commands, it's not a real problem.Also fixed some type warnings in
CortexMrelated to core register read return values being either int or float, though they weren't actual errors.