Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
hoodmane committed Jan 30, 2025
1 parent c7857eb commit 3e57e1f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions pyodide_build/pypabuild.py
Original file line number Diff line number Diff line change
Expand Up @@ -243,11 +243,11 @@ def make_command_wrapper_symlinks(symlink_dir: Path) -> dict[str, str]:


@contextmanager
def _get_symlink_dir(env: dict[str, str], build_dir: Path | None):
def _create_symlink_dir(env: dict[str, str], build_dir: Path | None):
if build_dir:
# If we're running under build-recipes, leave the symlinks in
# the build directory. This helps with reproducing.
symlink_dir = build_dir / "symlinks"
symlink_dir = build_dir / "pywasmcross_symlinks"
shutil.rmtree(symlink_dir, ignore_errors=True)
symlink_dir.mkdir()
yield symlink_dir
Expand Down Expand Up @@ -288,7 +288,7 @@ def get_build_env(
args["exports"] = exports
env = env.copy()

with _get_symlink_dir(env, build_dir) as symlink_dir:
with _create_symlink_dir(env, build_dir) as symlink_dir:
env.update(make_command_wrapper_symlinks(symlink_dir))
sysconfig_dir = Path(get_build_flag("TARGETINSTALLDIR")) / "sysconfigdata"
args["PYTHONPATH"] = sys.path + [str(symlink_dir), str(sysconfig_dir)]
Expand Down

0 comments on commit 3e57e1f

Please sign in to comment.