MAINT Subclass recipe builders #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanking13
commented
Sep 25, 2024
| @@ -412,6 +375,105 @@ def _compile( | |||
| self.src_extract_dir, self.src_dist_dir, build_env, config_settings | |||
| ) | |||
|
|
|||
| def _patch(self) -> None: | |||
There was a problem hiding this comment.
There is no change in _patch or other functions. It seems git diff is not smart enough to create a small diff.
…ide-build into subclass-builder
for more information, see https://pre-commit.ci
agriyakhetarpal
approved these changes
Dec 20, 2024
|
Prettier was quite helpful for me when linting YAML files for GitHub Actions, but I have no objections to removing it. We can use the VS Code extension for that. |
|
Thanks for the review!
Yeah, it is. But mirrors-prettier is deprecated, so I think we should drop it. There aren't much yaml files in this repository so I think it is okay |
ryanking13
added a commit
that referenced
this pull request
Dec 23, 2024
#36 had a bug not supporting `cpython_module` type recipes. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subclasses RecipeBuilder based on the package type. This is to make it easier to distinguish between behavior that varies by package type. No functional changes intended.
I'll update the
buildall.pyas a follow-up.I also removed prettier from the pre-commit, which I don't think is very useful for pyodide-build.