Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests: fix orjson's builds with Maturin 1.8, and bump to NumPy v2 #76

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

agriyakhetarpal
Copy link
Member

Description

Please see pyodide/pyodide#5283 for the context behind this change. This PR updates orjson to https://github.com/ijl/orjson/releases/tag/3.10.13 which fixed a missing version attribute in the project's declarative metadata, which resulted in a regression with https://github.com/PyO3/maturin/releases/tag/v1.8.0

Additional context

@agriyakhetarpal agriyakhetarpal changed the title Fix orjson's builds with Maturin 1.8 Integration tests: fix orjson's builds with Maturin 1.8, and bump to NumPy v2 Jan 2, 2025
@agriyakhetarpal
Copy link
Member Author

I switched to NumPy v2 to fix the integration test, as I suggested in #65 (comment). I'll self-merge since this is a trivial PR that doesn't add any functionality. Thanks!

@agriyakhetarpal agriyakhetarpal merged commit 1cce162 into pyodide:main Jan 2, 2025
5 checks passed
@agriyakhetarpal agriyakhetarpal deleted the fix/orjson-recipe branch January 2, 2025 20:42
@hoodmane
Copy link
Member

hoodmane commented Jan 2, 2025

Thanks @agriyakhetarpal !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants