Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop python 3.7 for cibuildwheel driver #1526

Merged
merged 3 commits into from
Jul 9, 2023

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Jun 17, 2023

This drops python 3.7 for cibuildwheel.
Building python 3.6 / 3.7 packages is still supported.

Copy link
Contributor

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a week early, but it makes sense to do with a minor point bump, which #1525 requires too, so doing them together makes sense.

@henryiii
Copy link
Contributor

Could you bump ruff too? Maybe I can from my phone, actually…

Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely stuff, thank you @mayeut. Let's just hold on merging this for a few days in case we need to get a patch release out in the meantime.

@henryiii
Copy link
Contributor

3.7's EoL is today.

exclude: ^cibuildwheel/resources/.*py$
args: ["--python-version=3.7"]
args: ["--python-version=3.8"]
additional_dependencies: &mypy-dependencies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, the markdown-it-py cap below can be removed, it was there to support Python 3.7.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather be explicit here if it's OK.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean “markdown-it-py<3” can be removed. I can’t comment on the correct line.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I misunderstood completely.
will do

mayeut and others added 3 commits July 1, 2023 14:33
This drops python 3.7 for cibuildwheel.
Building python 3.6 / 3.7 packages is still supported.
Since it's an indirect dependency (of rich), just remove the line altogether.
@henryiii
Copy link
Contributor

henryiii commented Jul 3, 2023

I'll probably retry #1297 after this goes in.

@henryiii
Copy link
Contributor

henryiii commented Jul 8, 2023

for a few days

It's been three weeks. I'd like to get something out before SciPy next week.

@joerick
Copy link
Contributor

joerick commented Jul 9, 2023

My apologies, I was holding out for a minor release but had forgotten that #1525 went in a couple of weeks back.

(I wasn't too happy with this being the only reason for a minor version bump)

@joerick joerick merged commit 740f081 into pypa:main Jul 9, 2023
@mayeut mayeut deleted the drop-python-3.7 branch July 29, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants