Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add musllinux_1_2 support #1561

Merged
merged 3 commits into from
Aug 7, 2023
Merged

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Jul 29, 2023

musllinux_1_2 support has been merged in the manylinux repo.
Now adding this to cibuildwheel.

@mayeut
Copy link
Member Author

mayeut commented Jul 30, 2023

The test error on GHA is: error: could not create 'build/temp.linux-i686-cpython-310': No space left on device
Similar error on Azure: failed to register layer: ApplyLayer exit status 1 stdout: stderr: write /var/lib/rpm/Packages: no space left on device

I'll try to check what can be done.
It's also happening on main: https://github.com/pypa/cibuildwheel/actions/runs/5651983407/job/15310948712#step:9:362

We are reaching disk space limits (14 GB) when running tests.
Add a fixture to clean-up docker images after tests.
This fixture is applied on tests that pull a specific image for one test only in order not to take too much time pulling that image many times.
@henryiii henryiii merged commit 36049d8 into pypa:main Aug 7, 2023
19 checks passed
Comment on lines +34 to +57
@pytest.fixture()
def docker_cleanup() -> Generator[None, None, None]:
def get_images() -> set[str]:
images = subprocess.run(
["docker", "image", "ls", "--format", "{{json .ID}}"],
text=True,
check=True,
stdout=subprocess.PIPE,
).stdout
return {json.loads(image.strip()) for image in images.splitlines() if image.strip()}

if detect_ci_provider() is None or platform != "linux":
try:
yield
finally:
pass
return
images_before = get_images()
try:
yield
finally:
images_after = get_images()
for image in images_after - images_before:
subprocess.run(["docker", "rmi", image], check=False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@mayeut mayeut deleted the musllinux_1_2 branch August 8, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants