Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CircleCI support #1576

Closed
wants to merge 5 commits into from
Closed

Update CircleCI support #1576

wants to merge 5 commits into from

Conversation

LecrisUT
Copy link

Circle CI now supports windows and MacOS-arm

Have not tested to confirm cibuldwheel is compatible with it though

@Czaki
Copy link
Contributor

Czaki commented Aug 14, 2023

The CircleCI OSS plan do not cover runs on MacOS and Windows.

CircleCI offers free access to compute time and resources for organizations on our Free plan. Open source projects can access up to 400,000 credits per month (equivalent to 80,000 build minutes) to use on Linux, Arm, and Docker.

Open source Windows and macOS builds or private repositories can use the 30,000 credits offered in our free plan.

I'm not sure if this 30 000 is enough for cibuildwheel

@LecrisUT
Copy link
Author

LecrisUT commented Aug 14, 2023

Those limits might change. I've also found this post about the macos.x86 being deprecated in a few months. Wouldn't other vendors do a similar deprecation? But also the 30,000 limit is valid for regular macos as well. If the CI is only run on workflow_dispatch and is limited to macos.arm, with the rest being handled by GH Action, I think it will be doable. BTW, Cirrus-CI is introducing a similar limitation as well.

@henryiii
Copy link
Contributor

Oops, triggered CI, thought this added testing. All the advertised platforms are tested by us.

@LecrisUT
Copy link
Author

I have just tried to setup a macos-arm runner on CircleCI, but it is reporting that resource is not available. After some digging it appears that you need to contact them for macos builders for foss projects, but they are currently reporting that macos-arm is only available for Performance Plan. Although windows runner should be supported according to their pricing plan.

I have requested for some clarification in regards to the deprecation notice and will update about that once they reply.

@LecrisUT
Copy link
Author

LecrisUT commented Sep 8, 2023

I have received confirmation that in December there will be m1.free variants https://discuss.circleci.com/t/macos-intel-support-deprecation-in-january-2024/48718

@joerick
Copy link
Contributor

joerick commented Sep 18, 2023

cibuildwheel does have a OSS permission for the macos builders, so it might get the same for windows too. @LecrisUT could you try adapting the CircleCI config at .circleci/config.yml to add these platforms? If we can test them as part of our CI, I'd be happy advertising support on the README.

@LecrisUT
Copy link
Author

@joerick I think I can make that change, but it would need to be re-run when the free macos-m1 builders are available. I could try and add the windows variants though.

If you look at https://circleci.com/pricing/, at the Resource Classes/macOS VM you'll see that M1 variants are still unavailable. From the other blog it seems there will be a new resource class for m1.free which will probably have a different name.

@joerick
Copy link
Contributor

joerick commented Nov 24, 2023

The pypa org has Open Source credits on CircleCI, so I've added the config to test macOS ARM there too.

image

Also good to see that we're not close to the limit so an extra runner shouldn't hurt.

@joerick
Copy link
Contributor

joerick commented Nov 24, 2023

You were right @LecrisUT - the current pypa plan gets credits, but no M1 builders (yet). that's scheduled to change early next year I believe.

@joerick
Copy link
Contributor

joerick commented Dec 6, 2023

Let's revisit this when the M1 runners are released.

@joerick joerick closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants