Don't require --platform when running on a development machine
#1727
Conversation
Historically, we required `--platform` when running cibuildwheel outside of CI, because cibuildwheel would attempt to globally install Python interpreters and some packages. That was fixed in #974 a couple of years ago. As a result, there's no reason to require --platform these days, the `auto` behaviour is perfectly fine for dev machines. It also makes running tests locally simpler, one can just do `pytest test/test_0_basic.py` (or `nox -s tests -- test/test_0_basic.py`) and not have to worry about setting CIBW_PLATFORM most of the time.
| options = intercepted_build_args.args[0] | ||
|
|
||
| # check that the platform was auto detected to build for the current system | ||
| if sys.platform.startswith("linux"): |
There was a problem hiding this comment.
nit: this feels like too much logic in a test. Any chance to simplify it?
There was a problem hiding this comment.
I know what you mean, it's essentially just repeating the logic in the main program. But I would like to be sure that both auto and unspecified are doing the right thing. A little extra verbosity in the test seems like a small price to pay IMO.
There was a problem hiding this comment.
In that case, why not try solving this on the level of parametrization? It'd be even clearer if it shows up in the test report.
There was a problem hiding this comment.
Even not parametrization but simeple dict could solve this:
platform_dkt = {"linux": "linux", "darwin": "macos", "win32": "windows"}
assert sys.platform in platform_dkt, f"Unknown platform: {sys.platform}"
assert platform_dkt[sys.platform] == options.platformThere was a problem hiding this comment.
While I appreciate the focus on craft and code quality, there becomes a point when it's not worth our time to debate such minor points. Especially in tests, where the control flow complexity is so low, because each test is an isolated execution. All that matters in a test is the actions that are taken and the asserts that are reached - if these are clear to the reader, it's fine. If they grow to become unmaintainable, it's easy to rewrite them.
cibuildwheel 2.17 doesn't need the "--platform" flag any more for local builds, so get rid of that for simpler code (pypa/cibuildwheel#1727).
cibuildwheel 2.17 doesn't need the "--platform" flag any more for local builds, so get rid of that for simpler code (pypa/cibuildwheel#1727).
cibuildwheel 2.17 doesn't need the "--platform" flag any more for local builds, so get rid of that for simpler code (pypa/cibuildwheel#1727).
cibuildwheel 2.17 doesn't need the "--platform" flag any more for local builds, so get rid of that for simpler code (pypa/cibuildwheel#1727).
cibuildwheel 2.17 doesn't need the "--platform" flag any more for local builds, so get rid of that for simpler code (pypa/cibuildwheel#1727). (cherry picked from commit 46b0e43)
cibuildwheel 2.17 doesn't need the "--platform" flag any more for local builds, so get rid of that for simpler code (pypa/cibuildwheel#1727). (cherry picked from commit 46b0e43)
cibuildwheel 2.17 doesn't need the "--platform" flag any more for local builds, so get rid of that for simpler code (pypa/cibuildwheel#1727). (cherry picked from commit 46b0e43)
Historically, we required
--platformwhen running cibuildwheel outside of CI, because cibuildwheel would attempt to globally install Python interpreters and some packages.That was fixed in #974 a couple of years ago. As a result, there's no reason to require --platform these days, the
autobehaviour is perfectly fine for dev machines.It also makes running tests locally simpler, one can just do
pytest test/test_0_basic.py(ornox -s tests -- test/test_0_basic.py) and not have to worry about setting CIBW_PLATFORM most of the time.