-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(action): do not use pipx #1745
Conversation
Let's see if they re-add pipx, which I'd really hope they do. I should have limited the workaround to a subset of runners (macos-14 only? macos-13-xlarge? Ideally only AS arch only?) |
(It can also break later steps if people are doing things with setup-python and need a clean environments that doesn't have pipx's dependencies installed. |
Should we take these out of draft? I don't think pipx / built-in Python is coming back soon, and am fine with the workaround. (Also wntrblm/nox#768) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I noticed a CI job is failing again on macOS due to the missing pipx when updating to the latest cibuildwheel release: nightlark/swig-pypi#123 Is there a recommended alternative (aside from migrating to scikit-build-core now)? Currently using pyproject.toml |
Migrating sounds good. :) But GHA is shipping pipx in the next image deployment. And you can pre-install pipx yourself in the mean time. |
Alright, good to hear -- looks like for now it will be pre-installing pipx, and hopefully soon get the migration to scikit-build-core merged. 😄 |
If #1743 is just meant to be temporary while waiting on actions/runner-images#9256, then that's ok.
However, if we need this in the long run, I'd rather not change the worker default environment. It's not necessarily an issue for github-hosted workers which are ephemeral but it could became an issue for self-hosted.