Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add musllinux armv7l #2017

Merged
merged 5 commits into from
Oct 1, 2024
Merged

feat: add musllinux armv7l #2017

merged 5 commits into from
Oct 1, 2024

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Sep 22, 2024

close #1421

Only musllinux was asked in the description of the linked issue but the title is broader so we may want to rework the title or not close the issue.

Now that the multi-arch images support has landed, workarounds to build armv7l wheels can't be used anymore so getting musllinux armv7l also allows to get workarounds working again to build manylinux armv7l if need be.

cibuildwheel/oci_container.py Show resolved Hide resolved
@mayeut mayeut requested a review from joerick September 29, 2024 10:40
@mayeut
Copy link
Member Author

mayeut commented Sep 29, 2024

I added another commit as this was failing for local armv7l images

cibuildwheel/oci_container.py Outdated Show resolved Hide resolved
cibuildwheel/oci_container.py Outdated Show resolved Hide resolved
@henryiii henryiii changed the title feature: add musllinux armv7l feat: add musllinux armv7l Oct 1, 2024
@henryiii henryiii merged commit 9fad66f into pypa:main Oct 1, 2024
25 checks passed
@mayeut mayeut deleted the armv7 branch October 1, 2024 16:48
@2bndy5
Copy link

2bndy5 commented Oct 5, 2024

this comes from the fact that a 32 bit kernel will report armv7l but a 64 bit kernel running linux32 emulation in an armv7 image will report armv8l so it's required to build armv7l on aarch64 runners.

So, to use this, I would need qemu setup for aarch64?

      - name: Set up QEMU
        uses: docker/setup-qemu-action@v3
        with:
          platforms: aarch64

      - name: Build wheels with cibuildwheels
        uses: pypa/[email protected]
        env:
          CIBW_ARCHS_LINUX: aarch64 native armv7l

It would be nice to have an example for armv7l in the docs somewhere, just to be more explicit than an implicit mention in the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arm32 / armv7l wheels
4 participants