fix: respect three components Python version #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, a `requires-python` version constraint of three components (e.g. `==3.11.4`) caused hatchling to fail detecting the supported Python versions and create invalid wheel filenames such as `mypackage-0.1.0--none-any.whl`. This fix takes micro versions into account as well and produces for the above three components version constraint the expected filename `mypackage-0.1.0-py3-none-any.whl`.
|
This operation is really slow now so I'm going to push a commit to improve performance this evening. |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
Co-authored-by: Ofek Lev <[email protected]> dd727c5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, a
requires-pythonversion constraint of three components (e.g.==3.11.4) caused hatchling to fail detecting the supported Python versions and create invalid wheel filenames such asmypackage-0.1.0--none-any.whl. This fix takes micro versions into account as well and produces for the above three components version constraint the expected filenamemypackage-0.1.0-py3-none-any.whl.Related discussion: #1277