Import PEP 668 specification #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willingc
approved these changes
Nov 12, 2023
|
Thank you for merging, @willingc. |
chrysle
reviewed
Nov 12, 2023
Comment on lines
+236
to
+238
| Error-de_DE=Wenn ist das Nunstück git und Slotermeyer? | ||
|
|
||
| Ja! Beiherhund das Oder die Virtualenvironment gersput! |
There was a problem hiding this comment.
This German example is outright horrible.... No wonder codespell complains.
We're in a bad spot; codespell doesn't support inline ignores. I don't think passing --ignore-regex to the hook is the best idea.
There was a problem hiding this comment.
We could take a look at https://github.com/python/peps/blob/main/.codespell/exclude-file.txt.
There was a problem hiding this comment.
This German example is outright horrible....
There was a problem hiding this comment.
They should add a warning next time ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to #1337 and #1340.
The first commit imports the PEP text as-is. All changes are done in the second commit so that reviewers can see what changed exactly. It is mostly trimming rationale/motivation sections and fixing markup for the PUG.