Skip to content

dependency-groups cross link Added in Pyproject.toml page #1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Daksh2000
Copy link

@Daksh2000 Daksh2000 commented Apr 14, 2025

@Daksh2000 Daksh2000 changed the title dependency-groups specification cross link Added dependency-groups specification cross link Added in Pyproject.toml page Apr 14, 2025
@Daksh2000 Daksh2000 changed the title dependency-groups specification cross link Added in Pyproject.toml page dependency-groups cross link Added in Pyproject.toml page Apr 14, 2025
@webknjaz webknjaz requested a review from ncoghlan April 14, 2025 20:31
Copy link
Member

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline suggestion to streamline a couple of the paragraphs, but this generally looks good to me. Thanks!

@webknjaz webknjaz requested a review from ncoghlan May 30, 2025 12:01
Copy link
Member

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@ncoghlan ncoghlan enabled auto-merge June 1, 2025 03:52
@webknjaz
Copy link
Member

webknjaz commented Jun 1, 2025

The CI didn't run because the last commit coincided w/ GH outage. I clicked "rebase" to trigger it.

@Daksh2000
Copy link
Author

The CI didn't run because the last commit coincided w/ GH outage. I clicked "rebase" to trigger it.

Hi , I could update the branch again if thats alright ?

@webknjaz
Copy link
Member

webknjaz commented Jun 1, 2025

You could. But the CI failure look unrelated to your PR and should be fixed in a separate one.

Since rebasing force-pushed the branch in your fork, it's best for you to git pull --rebase locally so Git wouldn't create a merge commit when you sync.

That said, the CI failure is not a reason for you to touch the branch. We just have to wait for the link fix. You can send a PR for that yourself, if you want.

@Daksh2000
Copy link
Author

You could. But the CI failure look unrelated to your PR and should be fixed in a separate one.

Since rebasing force-pushed the branch in your fork, it's best for you to git pull --rebase locally so Git wouldn't create a merge commit when you sync.

That said, the CI failure is not a reason for you to touch the branch. We just have to wait for the link fix. You can send a PR for that yourself, if you want.

Hi, Created a PR - #1868

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing dependency-groups specification cross link
4 participants