-
Notifications
You must be signed in to change notification settings - Fork 1.2k
dependency-groups cross link Added in Pyproject.toml page #1847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inline suggestion to streamline a couple of the paragraphs, but this generally looks good to me. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
Co-authored-by: Alyssa Coghlan <[email protected]>
Co-authored-by: Alyssa Coghlan <[email protected]>
The CI didn't run because the last commit coincided w/ GH outage. I clicked "rebase" to trigger it. |
Hi , I could update the branch again if thats alright ? |
You could. But the CI failure look unrelated to your PR and should be fixed in a separate one. Since rebasing force-pushed the branch in your fork, it's best for you to That said, the CI failure is not a reason for you to touch the branch. We just have to wait for the link fix. You can send a PR for that yourself, if you want. |
Hi, Created a PR - #1868 |
Fixes: #1840
📚 Documentation preview 📚: https://python-packaging-user-guide--1847.org.readthedocs.build/en/1847/