Skip to content

Commit

Permalink
Stop explicitly listing wheel as a build dependency (#12728)
Browse files Browse the repository at this point in the history
* Stop explicitly listing wheel as a build dependency

setuptools' get_requires_for_build_wheel() hook already injects this dependency
when building wheels is requested.

See also 64d8938.

* Fix typo in news fragment

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>

---------

Co-authored-by: Tzu-ping Chung <[email protected]>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
  • Loading branch information
3 people authored Jul 9, 2024
1 parent 34e70ba commit 6b35bee
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions news/12728.feature.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
``wheel`` is no longer explicitly listed as a build depepndency of ``pip``.
``setuptools`` already injects this dependency in the ``get_requires_for_build_wheel()`` hook.
This makes no difference for users of ``pip``.
This makes no difference when building wheels of ``pip``.
This avoids an unnecessary dependency on ``wheel`` when building the source distribution of ``pip``.
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ Changelog = "https://pip.pypa.io/en/stable/news/"

[build-system]
# The lower bound is for <https://github.com/pypa/setuptools/issues/3865>.
requires = ["setuptools>=67.6.1", "wheel"]
requires = ["setuptools>=67.6.1"]
build-backend = "setuptools.build_meta"

[tool.setuptools]
Expand Down

0 comments on commit 6b35bee

Please sign in to comment.