Skip to content

Commit

Permalink
ci: Test packaging flow on Windows
Browse files Browse the repository at this point in the history
Most of pip's maintainers use non-Windows environments, so it's easy for
our tooling to regress on Windows. Let's avoid that for our release
flow.

In addition, remove the dependency on the packaging job by the test
jobs. The packaging job rarely fails so we aren't saving any CI
resources by failing early if the packaging job fails.
  • Loading branch information
ichard26 committed Jan 26, 2025
1 parent f5ff4fa commit e66ad83
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,11 @@ jobs:
if: github.event_name == 'pull_request'

packaging:
name: packaging
runs-on: ubuntu-22.04
name: packaging / ${{ matrix.os }}
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-22.04, windows-latest]

steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -104,7 +107,7 @@ jobs:
name: tests / ${{ matrix.python.key || matrix.python }} / ${{ matrix.os }}
runs-on: ${{ matrix.os }}

needs: [packaging, determine-changes]
needs: [determine-changes]
if: >-
needs.determine-changes.outputs.tests == 'true' ||
github.event_name != 'pull_request'
Expand Down

0 comments on commit e66ad83

Please sign in to comment.