dry-run and fast-deps behavior testing #12193
Merged
+110
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @sbidoul @pradyunsg @uranusjr no rush at all; github doesn't allow me to request reviewers (which is fine). |
cosmicexplorer
force-pushed
the
metadata-behavior-testing
branch
2 times, most recently
from
913c02f
to
d6e77fb
Compare
cosmicexplorer
force-pushed
the
metadata-behavior-testing
branch
from
d6e77fb
to
1c86633
Compare
cosmicexplorer
force-pushed
the
metadata-behavior-testing
branch
2 times, most recently
from
08ce2fa
to
700af48
Compare
uranusjr
reviewed
Aug 9, 2023
uranusjr
reviewed
Aug 9, 2023
uranusjr
approved these changes
Aug 9, 2023
cosmicexplorer
force-pushed
the
metadata-behavior-testing
branch
2 times, most recently
from
9c52698
to
700af48
Compare
|
@pfmoore this is also probably easy to review and merge. |
cosmicexplorer
force-pushed
the
metadata-behavior-testing
branch
from
700af48
to
20b54de
Compare
pfmoore
approved these changes
Aug 12, 2023
There was a problem hiding this comment.
No real objections to any of this, but there are a few places I wouldn't describe the new code as "clear". That's a matter of opinion, and I'm unlikely to look at these tests very often in future anyway, so I don't want to block the PR because of it, but if it could be simplified/clarified, that would be good.
cosmicexplorer
changed the title
pip install behavior testing
cosmicexplorer
changed the title
pip install behavior testing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #12186. In that change, we found that multiple behaviors we expected from
install --dry-runweren't tested. This change tests that:install --dry-runis specified.Pip already does these correctly, but now we can be sure.
This also modifies another test (
test_trailing_slash_directory_metadata()) to avoid using.get_dist(). This version of the test is more correct and avoids a reliance on.get_dist(), which will be removed in #12186.