Detect recursively referencing requirements files #12877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellozee
force-pushed
the
recursive-requirements
branch
from
4359e34
to
7072473
Compare
It absolutely is! :) |
hellozee
force-pushed
the
recursive-requirements
branch
from
0e88754
to
7698545
Compare
uranusjr
reviewed
Aug 20, 2024
uranusjr
reviewed
Aug 20, 2024
uranusjr
reviewed
Aug 22, 2024
uranusjr
approved these changes
Aug 22, 2024
hellozee
force-pushed
the
recursive-requirements
branch
from
96e5d2f
to
8d15e3b
Compare
|
Sorry rebased the PR on main without pulling first. Fortunately, the extra patch was a trivial one 😓 |
|
This may have caused a regression: #13046 |
|
And a tentative fix is in #13047 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12653
I am not sure if I am allowed to put out patches for issues with "needs triage" labels, but seems like simple fix and I got to scratch my own itch too.
Also I am not exactly sure that this is how it should be fixed, but it does catch the files with the problem in the correct order. Had to convert the files to absolute path, else in case of nested references which goes up the directory hierarchy it can't catch the recursion.