Skip to content

Tests: Add various missing @pytest.mark.network markers #13385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

hroncok
Copy link
Contributor

@hroncok hroncok commented May 6, 2025

It pip installs keyring

@hroncok hroncok changed the title Tests: test_prompt_for_keyring_if_needed requires network Tests: test_prompt_for_keyring_if_needed and test_double_install_fail require network May 6, 2025
It runs pip in subprocess to install build dependencies from internet.
@hroncok hroncok changed the title Tests: test_prompt_for_keyring_if_needed and test_double_install_fail require network Tests: Add various missing @pytest.mark.network markers May 6, 2025
hroncok added 2 commits May 6, 2025 10:40
    E               RuntimeError: stderr has an unexpected warning (pass allow_stderr_warning=True to permit this):
    E                Caused by line: "WARNING: Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7f12b0a1f4d0>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution')': /simple/foo/"
    E                Complete stderr: WARNING: Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7f12b0a1f4d0>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution')': /simple/foo/
    E               WARNING: Retrying (Retry(total=3, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7f12b0ad0a50>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution')': /simple/foo/
    E               WARNING: Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7f12b0ad0cd0>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution')': /simple/foo/
    E               WARNING: Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7f12b0ad0f50>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution')': /simple/foo/
    E               WARNING: Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7f12b0ad11d0>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution')': /simple/foo/
@hroncok
Copy link
Contributor Author

hroncok commented May 6, 2025

Does this require a changelog entry?

Should I squash or keep individual commits?

@ichard26
Copy link
Member

ichard26 commented May 6, 2025

@mgorny beat you to this :)

#13378

@ichard26 ichard26 closed this May 6, 2025
@hroncok
Copy link
Contributor Author

hroncok commented May 7, 2025

I have verified that #13378 includes everything from this one.

Sorry about that, I should have searched better.

@hroncok hroncok deleted the keyring-network branch May 7, 2025 07:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants