-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update table
and add information about staggered migrations
#22
Conversation
Thanks for the work! But is it now staggered or staged migrations? If it's not of importance, I'd prefer the latter. |
Hi @chrysle, I am not a native speaker, so I am just replicating the words that were proposed by Jason in pypa/setuptools#3434. |
Me neither ;-) Referring to that, the term staged migration came up in zopefoundation/meta#194 (comment). Since that sounds much more "planned", could you update the PR to it?
|
@abravalheri Please let me know what concerns you have concerning the naming. |
table
and add information about staggered migrations.table
and add information about staggered migrations
Hi @chrysle sorry I let this one slip... No I am fine with whichever words people think will make it clearer. |
Well, so I asked OALD, and to stagger seems to be a valid transitive (although that wasn't known to me), and the meaning of to stage I meant (of which I know it's possible) isn't even mentioned on the corresponding page.... So let's take the former ;) Could you rebase? |
Hi @chrysle, I solved the merge conflicts and also took the opportunity to ensure all tests were using Hopefully the CI will pass 🤞 |
Oh well, too soon.
That is kind of expected isn't? Some combinations will fail indeed. |
Thank you!
I actually made the CI pass in #24 (could you have a look at that?). I don't think there will be any more merge conflicts when that is merged. And @pradyunsg enabled that passing checks are required. |
I think #24 is going to be a big conflict with this one, isn't it? The original idea behind running |
Sorry if I screwed this up, I didn't find any documentation here that would explain this purpose. On the other hand, if you are able to run all scenarios correctly, isn't that more helpful to you? |
Oh no, I didn't mean you screw things up, sorry if I miscommunicated that. I think that adding more scenarios is good. But we should not remove scenarios that don't work (showing that they don't work is kind of the point). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Should we migrate all the examples to pyproject.toml
later on (probably keeping setup.py
s as samples)?
@abravalheri Gentle nudge to this, sorry for approving too early. |
Hi @chrysle, sorry for the delay. I am away from my computer this December and less responsive than usual. I will be able to have a look as soon as I come back in January. But I think it might make sense to separate into 2 PRs. |
No problem, take your time and enjoy your holiday!
That's my suggestion too. |
This opens space for more up-to-date results.
and modern backend APIS.
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]> Co-authored-by: chrysle <[email protected]>
I rebased the PR and updated the table with the latest output of |
Thanks a lot! |
After setuptools added deprecation warnings for
pkg_resources.declare_namespace
there has been a lot of doubt in the community about how to migrate away from it, and concerns about carrying out this migration in large projects (see pypa/setuptools#3434).The objective of this PR is to shed some light on the problem and help to answer the question "what happens if not all the packages sharing a namespace migrate at the same time?".
I took the opportunity to "modernize" the nox matrix, removing the deprecated installation method (using
python setup.py ...
) and adding some newer Python versions1.Please note that I did not add all active versions of Python to the matrix on purpose, because that would take too much time in my machine. So I am intentionally stepping away from this objective (if any one is interested in adding the missing Python version that would be a nice next step)2.
Footnotes
The motivation for this is twofold: we are a few moths away from the EoL of Python 3.7 and leaving Python 2.7 and
python setup.py ...
in the table would be distracting. ↩Another equally nice improvement would be using CI, but I am also intentionally removing this from the scope of this PR. ↩