Merge pull request #400 from gesslerpd/fix/windows

Fix #399: ensure the git file finder closes file descriptor after reading archive

CHANGELOG.rst

@@ -1,3 +1,8 @@
+v3.4.3
+======
+
+* fix #399: ensure the git file finder terminates subprocess after reading archive
+
 v3.4.2
 ======
 

src/setuptools_scm/file_finder_git.py

@@ -49,8 +49,8 @@ def _git_ls_files_and_dirs(toplevel):
         try:
             return _git_interpret_archive(proc.stdout, toplevel)
         finally:
-            # ensure we avoid ressource warnings by cleaning up the pocess
-            proc.wait()
+            # ensure we avoid resource warnings by cleaning up the process
+            proc.terminate()
     except Exception:
         if proc.wait() != 0:
             log.exception("listing git files failed - pretending there aren't any")