pkg_resources: Runtime fixes to make typing annotations work
#4262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
changed the title
pkg_resoruces: Runtime fixes to make typing annotations workpkg_resources: Runtime fixes to make typing annotations work
…soruces-typign-fixes-for-annotations
abravalheri
reviewed
Mar 8, 2024
pkg_resources/__init__.py
Outdated
| @@ -2825,7 +2825,7 @@ def activate(self, path=None, replace=False): | |||
| if path is None: | |||
| path = sys.path | |||
| self.insert_on(path, replace=replace) | |||
| if path is sys.path: | |||
| if path is sys.path and self.location: | |||
There was a problem hiding this comment.
I wonder if it is possible that self.location is an empty string...
The empty string is a valid entry for sys.path (and holds special meaning).
There was a problem hiding this comment.
Just in case:
Suggested change
| if path is sys.path and self.location: | |
| if path is sys.path and self.location is not None: |
But I am unsure if we should raise early or gracefully "do nothing" on None
Avasam
commented
Mar 8, 2024
abravalheri
reviewed
Mar 12, 2024
abravalheri
approved these changes
Mar 12, 2024
2 tasks
|
Thank you very much @Avasam. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Should fix the last errors in #4246. These are all actual code changes, please review carefully.
Pull Request Checklist
newsfragments/.(See documentation for details)