Skip to content

Short-circuit get_requires hooks when there are no extra build dependencies #4973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

Short-circuit get_requires hooks when there are no extra build dependencies #4973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions newsfragments/4973.feature.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
PEP 517 ``get_requires_for_build_sdist`` and ``get_requires_for_build_wheel`` hooks
now terminate as soon as it is determined there are no extra build dependencies.
7 changes: 5 additions & 2 deletions setuptools/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,11 @@ def finalize_options(self):

# Honor setup.cfg's options.
dist.parse_config_files(ignore_option_errors=True)
if dist.setup_requires:
_fetch_build_eggs(dist)
# NOTE: fetch_build_eggs is called so even if there are no build
# requirements, get_requires_for_build_(sdist/wheel) will still
# short-circuit once build dependencies are known (avoiding the
# costly full execution of setup.py).
_fetch_build_eggs(dist)


def _fetch_build_eggs(dist: Distribution):
Expand Down
Loading