Stop including 'wheel', setuptools 70.1 has native bdist_wheel support #2868
+66
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanor
force-pushed
the
no-wheel
branch
5 times, most recently
from
bce9ebb to
d0cb03a
Compare
stefanor
commented
Apr 10, 2025
stefanor
commented
Apr 10, 2025
|
The two blockers are resolved. Note that this PR now bumps the bundled pip (except for Python 3.8, which I assume we'll remove shortly). |
stefanor
commented
Apr 27, 2025
stefanor
commented
Apr 28, 2025
gaborbernat
approved these changes
Apr 28, 2025
hroncok
reviewed
Apr 29, 2025
stefanor
added a commit
to stefanor/cffi
that referenced
this pull request
Apr 29, 2025
…these tests Previously we relied on pip to build the packages in non-PEP517 mode, which implied no build isolation. The latest `virtualenv` (with pypa/virtualenv#2868) won't include `wheel` in the virtualenv, which will mean that pip uses PEP-517 mode, which is isolated by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setuptools has native
bdist_wheelsupport these days, so I don't think it's necessary to bundle thewheellibrary any more. Or am I missing something?Possibly we could include a noop
--no-wheelargument (but I'm not sure where that would be best defined).Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)
tox -e fix)docs/changelogfolder