P200 DBSP misc updates #1849
Merged
P200 DBSP misc updates #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The control system for P200/DBSP automatically adjusts the FITS headers for datasec/oscansec based on the binning, so `get_rawimage` doesn't need to adjust the data sections based on binning. further info in commit 5f567d3
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1849 +/- ##
===========================================
+ Coverage 38.07% 38.09% +0.01%
===========================================
Files 211 211
Lines 49010 49000 -10
===========================================
+ Hits 18662 18665 +3
+ Misses 30348 30335 -13 ☔ View full report in Codecov by Sentry. |
When caching from GitHub using the script `pypeit_cache_github_data`, an error was kicked complaining about "Remote host type None is not supported for package data caching." This commit corrects the issue by specifying the `remote_host` in the instantiation of PypeItDataPath. modified: pypeit/scripts/cache_github_data.py
Specify `remote_host` in call to PypeItDataPath
Enable Spectrograph base class to account for image sections that include on-chip binning
kbwestfall
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
I added some notes to the change log.
The CI failures are related to the recent astropydev change to the minimum python version. We'll need to merge #1854 before this one.
tbowers7
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix binning issue brought up in PypeIt Users Slack.
Add reid_arxiv template for 1200/7100 with D55 dichroic