Fixes the WCS used for weighted combination #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbwestfall
approved these changes
Dec 3, 2024
|
Tests pass... There's a corresponding dev suite PR as well. 
|
Thanks for the suggestion @kbwestfall. I'm quite keen to add tests for KCWI, to avoid breaking things I've put in the code long ago! But, I don't think this is really something where a test would help. The issue was that arcsec^2 was a negative number (because the WCS is flipped E-W), and the number of bins was incorrectly set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of RA points used in the white light image generated when calculating the weights was incorrect. This is now fixed.
Running tests...