Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement unit testing for extra-functionality constraints in the solving script #1203

Open
ekatef opened this issue Nov 20, 2024 · 1 comment

Comments

@ekatef
Copy link
Member

ekatef commented Nov 20, 2024

Describe the feature you'd like to see

We have a number of functions in solve_network script which implements diverse extra-constraints for the model, while they testing could have been limited up to the data. Examples: add_chp_constraints or add_EQ_constraints

Given the domain significance of these functionality, unit testing can work perfectly there to ensure stability against regression. The implementation approach can contain of the following steps:

  • refactoring of the solving scripts
  • debug and introducing fixes for all the functions in question
  • formulation requirements of UT for each function
  • implementation of UT themselves.
@ekatef
Copy link
Member Author

ekatef commented Nov 20, 2024

FYI @GbotemiB
May you be interested to formulate the requirements for unit testing? I remember that you have still be testing add_chp_constraints which could give great insights for this task.

As a comment, that is crucial to understand what exactly do we aim to check to maintain the balance between simplicity, ability to capture bugs and stability to false-positive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant