-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent unwanted subprocess termination #1079
Open
ollie-bell
wants to merge
9
commits into
pypsa-meets-earth:main
Choose a base branch
from
ollie-bell:fix-cutout-terminate-subprocess
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c455324
fix: prevent unwanted subprocess termination
ollie-bell d6e2cf6
Update release_notes.rst
ollie-bell a5e7d60
refactor: more robust subprocess detection
ollie-bell ba132e8
test: snakemake subprocess termination fix
ollie-bell 6d149be
Merge branch 'main' into fix-cutout-terminate-subprocess
ollie-bell ba4bb0c
test: snakemake subprocess termination fix - update snakefile
ollie-bell 2b451e4
chore: add license info for pre-commit
ollie-bell 6fddd70
Merge branch 'fix-cutout-terminate-subprocess' of github.com:ollie-be…
ollie-bell 909c220
Rename test_cutout_termination to test_cutout_termination.smk
ollie-bell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
# SPDX-FileCopyrightText: PyPSA-Earth and PyPSA-Eur Authors | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Many thanks for the test example! :) |
||
# | ||
# SPDX-License-Identifier: AGPL-3.0-or-later | ||
|
||
import os | ||
import sys | ||
|
||
CUTOUT = "cutout.nc" | ||
|
||
|
||
def terminate_if_cutout_exists(subprocess_check=False): | ||
""" | ||
Check if any of the requested cutout files exist. | ||
If that's the case, terminate execution to avoid data loss. | ||
""" | ||
if subprocess_check: | ||
import argparse | ||
|
||
parser = argparse.ArgumentParser() | ||
parser.add_argument("--mode", type=int, default=snakemake.Mode.default) | ||
parser.add_argument("--target-jobs", type=str, nargs="+", default=[]) | ||
args, _ = parser.parse_known_args(sys.argv) | ||
if args.mode == snakemake.Mode.subprocess and "build_cutout" not in " ".join( | ||
args.target_jobs | ||
): | ||
return | ||
|
||
if os.path.exists(CUTOUT): | ||
os.remove(CUTOUT) | ||
raise Exception( | ||
f"A cutout file {CUTOUT} exists and risks to be overwritten. " | ||
"If this is an intended behavior, please move or delete this file and re-run the rule." | ||
) | ||
|
||
|
||
terminate_if_cutout_exists(subprocess_check=config.get("subprocess_check", False)) | ||
|
||
|
||
rule remove_cutout: | ||
input: | ||
cutout=CUTOUT, | ||
run: | ||
os.remove(input.cutout) | ||
|
||
|
||
rule build_cutout: | ||
output: | ||
cutout=CUTOUT, | ||
shell: | ||
"echo build_cutout > {output.cutout}" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind moving this up? :)